Re: [PATCH 2/2] page table iterators

[Hugh Dickins]

On Fri, 25 Feb 2005, Nick Piggin wrote:
> Hugh Dickins wrote:
> > 
> > Has anyone _ever_ seen a p??_ERROR message?  I'm inclined to just
> > put three functions into mm/memory.c to do the p??_ERROR and p??_clear,
> > but that way the __FILE__ and __LINE__ will always come out the same.
> > I think if it ever proves a problem, we'd just add in a dump_stack.
> 
> I think a function is the most sensible. And a good idea, it should
> reduce the icache pressure in the loops (although gcc does seem to
> do a pretty good job of moving unlikely()s away from the fastpath).

At one stage I was adding unlikelies to all the p??_bads, then it
seemed more sensible to hide that in a new macro (which of course
must do the none and bad tests inline, before going off to the function).

David's response confirms that __FILE__,__LINE__ shouldn't be an issue.

> I think at the point these things get detected, there is little use
> for having a dump_stack. But we may as well add one anyway if it is
> an out of line function?

We could at little cost.  But I think if these messages come up at all,
they're likely to come up in clumps, where the backtrace won't actually
be giving any interesting info, and the quantity of them be a nuisance
itself.  I'd rather leave it to the next person who gets the error and
wants the backtrace to add it.

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/