Re: [BK PATCHES] 2.6.x libata fixes (mostly)

From: Prakash Punnoor
Date: Wed Feb 23 2005 - 17:17:03 EST


Roland Dreier schrieb:
> Prakash> If I am not totally mistaken this is not gcc4 friendly
> Prakash> code. (lvalue thing...)
>
> Actually you misread the code slightly. It's a little subtle, but
> code like
>
> *(__le32 *)prd = cpu_to_le32(len);
>
> is not using a cast as an lvalue. It's dereferencing a cast and as
> such is totally correct, idiomatic and clean C.

OK, thanks for clearing that up. Obviously my C knowledge needs to be improved...

--
Prakash Punnoor

formerly known as Prakash K. Cheemplavam

Attachment: signature.asc
Description: OpenPGP digital signature