Re: [PATCH/RFC] Futex mmap_sem deadlock

[Andrew Morton]

olof@xxxxxxxxxxxxxx (Olof Johansson) wrote:
>
> +		inc_preempt_count();
> +		ret = get_user(curval, (int __user *)uaddr1);
> +		dec_preempt_count();

That _should_ generate a might_sleep() warning, except it looks like we
forgot to add a check to get_user().

It would be better to use __copy_from_user_inatomic() here, I think.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/