Re: [PATCH/RFC] Futex mmap_sem deadlock

[Jamie Lokier]

Chris Friesen wrote:
> >	down_read(&current->mm->mmap_sem);
> >	get_futex_key(...) etc.
> >	queue_me(...) etc.
> >	current->flags |= PF_MMAP_SEM;             <- new
> >	ret = get_user(...);
> >	current->flags &= PF_MMAP_SEM;             <- new
> >	/* the rest */
> 
> Should the second new line be this (with the inverse)?
> 
> 	current->flags &= ~PF_MMAP_SEM;

Quiet!  I was trying to sneak in a security hole! :)

-- Jamie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/