Re: [patch -mm series] ia64 specific /dev/mem handlers

[Andrew Morton]

Matthew Wilcox <matthew@xxxxxx> wrote:
>
> On Tue, Feb 22, 2005 at 09:41:04AM -0500, Jes Sorensen wrote:
>  > >> + if (page->flags & PG_uncached)
>  > 
>  > Andrew> dude.  That ain't gonna work ;)
>  > 
>  > Pardon my lack of clue, but why not?

	if (page->flags & (1<<PG_uncached))

would have been correcter.

>  I think you're supposed to always use test_bit() to check page flags

Yup.  Add PageUncached macros to page-flags.h.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/