RE: cciss CSMI via sysfs for 2.6

From: Miller, Mike (OS Dev)
Date: Tue Feb 22 2005 - 09:53:10 EST


> -----Original Message-----
> From: Toon van der Pas [mailto:toon@xxxxxxxxxxxxxxxxxxxxx]
> > +
> > + iocommand.IoctlHeader.Length = sizeof(CSMI_SAS_PHY_INFO_BUFFER);
> > + c->cmd_type = CMD_IOCTL_PEND;
> > + c->Header.ReplyQueue = 0;
> > +
> > + //Do we send the whole buffer?
> > + if (iocommand.IoctlHeader.Length > 0){
>
> This test will always be true, no?

Yes, I'll fix that.

Thanks,
mikem

>
> > + c->Header.SGList = 1;
> > + c->Header.SGTotal = 1;
> > + } else {
> > + c->Header.SGList = 0;
> > + c->Header.SGTotal = 0;
> > + }
>
> --
> "Debugging is twice as hard as writing the code in the first place.
> Therefore, if you write the code as cleverly as possible, you are,
> by definition, not smart enough to debug it." - Brian W. Kernighan
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/