martian source message is wrong?

[Francesco Potorti`]

In 2.6.10, in net/ipv4/route.c, this message is printed:

		printk(KERN_WARNING "martian source %u.%u.%u.%u from "
			"%u.%u.%u.%u, on dev %s\n",
			NIPQUAD(daddr), NIPQUAD(saddr), dev->name);

In my opinion, it should be:

!		printk(KERN_WARNING "martian source %u.%u.%u.%u to "
			"%u.%u.%u.%u, on dev %s\n",
!			NIPQUAD(saddr), NIPQUAD(daddr), dev->name);

or, alternatively,

!		printk(KERN_WARNING "martian source to %u.%u.%u.%u from "
			"%u.%u.%u.%u, on dev %s\n",
			NIPQUAD(daddr), NIPQUAD(saddr), dev->name);

As it is written, it is not clear whether the martian source address is
the first or the second one printed.

-- 
Francesco Potortì (ricercatore)        Voice: +39 050 315 3058 (op.2111)
ISTI - Area della ricerca CNR          Fax:   +39 050 313 8091
via G. Moruzzi 1, I-56124 Pisa         Email: Potorti@xxxxxxxxxxx
Web: http://fly.isti.cnr.it/           Key:   fly.isti.cnr.it/public.key
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/