Re: [PATCH] ohci1394: dma_pool_destroy while in_atomic() && irqs_disabled()

[Parag Warudkar]

On Saturday 19 February 2005 01:36 am, Jody McIntyre wrote:
> I disagree because the impact of this bug is small.  How often do you start
> an ISO receive?  If you think it needs to be fixed urgently, please
> explain why - maybe I'm just missing somethnig.
>

I have to agree that the impact is small even for the people using ISO recv - 
I happen to use it quite frequently and it hasn't locked up on me yet. So I 
certainly don't need it fixed atm. It's just the "dmesg annoyance" if you 
will, to deal with :) !

> I'm not sure, but I looked through the code and it seems to allocate:
>  - 16 buffers of 2x PAGE_SIZE (= 131072 on i386)
>  - 16 buffers of PAGE_SIZE (= 65536 on i386)
>  - various other smaller structures.

OTOH, if it allocates so much of memory while irqs disabled and holding locks, 
isn't there a  good chance for the allocator to sleep and things to go wrong?

Parag 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/