Re: [PATCH] 2.6.9 Use skb_padto() in drivers/net/8390.c

From: Alan Cox
Date: Sat Feb 19 2005 - 09:09:28 EST


On Sad, 2005-02-19 at 05:20, Jeff Garzik wrote:
> > It means that padto has improved a lot (or the underlying allocators).
> > It also still means the patch makes the code slower and introduces
> > changes that have no benefit into the kernel, so while its good to see
> > its not relevant its still a pointless change.
>
> So the verdict is to revert?

Not sure. The old code is known to work and a fraction faster, the new
code makes the driver use the same logic as the others. Having seen the
numbers from Paul I personally don't care either way.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/