Re: [patch] inotify for 2.6.11-rc3-mm2

[Al Viro]

On Fri, Feb 18, 2005 at 11:40:59AM -0500, Robert Love wrote:
> inotify, bitches

/me does "pick a random function, find a race" again.
 
> +/*
> + * inode_add_watch - add a watch to the given inode
> + *
> + * Callers must hold dev->lock, because we call inode_find_dev().
> + */
> +static int inode_add_watch(struct inode *inode, struct inotify_watch *watch)
[snip]
> +	list_add(&watch->i_list, &inode->inotify_data->watches);
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
... and that is protected by what?
> +
> +	return 0;

Fix the damn locking, already.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/