Re: [KJ] [PATCH] drivers/char/watchdog/* : pci_request_regions

[Jeff Garzik]

Matthew Wilcox wrote:
> On Mon, Feb 14, 2005 at 04:01:11PM +0100, Christophe Lucas wrote:
>
> > If PCI request regions fails, then someone else is using the
> > hardware we wish to use. For that one case, calling
> > pci_disable_device() is rather rude.
> > See : http://www.ussg.iu.edu/hypermail/linux/kernel/0502.1/1061.html
>
>
> Actually, that isn't necessarily true.  If the request_regions call fails,
> that can mean there's a resource conflict.  If so, leaving the device
> enabled is the worst possible thing to do as we'll now have two devices
> trying to respond to the same io accesses.

Incorrect.  If request_region() fails, drivers are coded to _not_ touch 
the hardware.  That's the entire purpose of the whole charade: to avoid 
having two devices responding to the same io accesses.

If your driver is talking to the hardware after request_region() fails, 
it is BROKEN plain and simple.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/