Re: Pty is losing bytes

From: Linus Torvalds
Date: Thu Feb 17 2005 - 10:47:14 EST




On Wed, 16 Feb 2005, Theodore Ts'o wrote:
>
> Yes, but then when the buffer is full, and we return the "we'll take
> anything" return value, the code that was getting confused with the
> "incorrect" receive_room value will still be getting confused....

But that's fine - at that point we're literally _supposed_ to drop
characters: we have to, in order to see the EOLN.

But we're only supposed to drop characters IFF:
- the buffer is full
- we are in canon mode
- we _still_ haven't seen a single EOLN in the whole buffer

If any of these three isn't true, we're not supposed to drop anything.

That's my argument.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/