Re: sil_blacklist - are all those entries necessary?

[Jeff Garzik]

Witold Krecicki wrote:
> in sata_sil.c there is:
> sil_blacklist [] = {
>         { "ST320012AS",         SIL_QUIRK_MOD15WRITE },
>         { "ST330013AS",         SIL_QUIRK_MOD15WRITE },
>         { "ST340017AS",         SIL_QUIRK_MOD15WRITE },
>         { "ST360015AS",         SIL_QUIRK_MOD15WRITE },
>         { "ST380023AS",         SIL_QUIRK_MOD15WRITE },
>         { "ST3120023AS",        SIL_QUIRK_MOD15WRITE },
>         { "ST3160023AS",        SIL_QUIRK_MOD15WRITE },
>         { "ST3120026AS",        SIL_QUIRK_MOD15WRITE },
>         { "ST340014ASL",        SIL_QUIRK_MOD15WRITE },
>         { "ST360014ASL",        SIL_QUIRK_MOD15WRITE },
>         { "ST380011ASL",        SIL_QUIRK_MOD15WRITE },
>         { "ST3120022ASL",       SIL_QUIRK_MOD15WRITE },
>         { "ST3160021ASL",       SIL_QUIRK_MOD15WRITE },
>         { "Maxtor 4D060H3",     SIL_QUIRK_UDMA5MAX },
>         { }
> };
> I've got ST3120026AS and I've been using it with SIL3112 without this hack for 
> a long time - without any negative effects. The same impression on 
> ST3200822AS - is there any way to check if it is REALLY necessary? 15MB/s is 
> not what I'd expect on SATA...

It's necessary until we can prove otherwise.  Simply running well 
without your drive in the blacklist means nothing -- you just haven't 
hit the error condition yet.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/