Re: [PATCH] Consolidate compat_sys_waitid

From: Andi Kleen
Date: Tue Feb 15 2005 - 06:13:28 EST


On Tue, Feb 15, 2005 at 10:06:14PM +1100, Stephen Rothwell wrote:
> Hi Andi,
>
> On Tue, 15 Feb 2005 10:51:53 +0100 Andi Kleen <ak@xxxxxxx> wrote:
> >
> > I don't think this will work for sparc64/s390/UML etc.
> > They cannot access kernel data inside KERNEL_DS. You would need to use
> > compat_alloc_user_space() for ru
>
> .. and, presumably, for info as well. Interestingly, this code
> came directly from sparc64 ...

Sorry, I misread the code. In this case it's actually ok.

The only thing that doesn't work is mixing the pointers (e.g. accessing
user mode pointers inside KERNEL_DS)

So the patch is fine.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/