Re: [PATCH] Fix ALPS sync loss

[Pete Zaitcev]

On Tue, 8 Feb 2005 18:40:12 -0500, Dmitry Torokhov <dtor_core@xxxxxxxxxxxxx> wrote:

> Here is the promised patch. It turns out protocol validation code was
> a bit (or rather a byte ;) ) off.

> +++ b/drivers/input/mouse/alps.c	2005-02-08 18:16:27 -05:00
> @@ -198,8 +198,8 @@
>  		return PSMOUSE_BAD_DATA;
>  
>  	/* Bytes 2 - 6 should have 0 in the highest bit */
> -	if (psmouse->pktcnt > 1 && psmouse->pktcnt <= 6 &&
> -	    (psmouse->packet[psmouse->pktcnt] & 0x80))
> +	if (psmouse->pktcnt >= 2 && psmouse->pktcnt <= 6 &&
> +	    (psmouse->packet[psmouse->pktcnt - 1] & 0x80))
>  		return PSMOUSE_BAD_DATA;

This seems to work here, no more dead pad.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/