Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm

[James Morris]

On Thu, 10 Feb 2005, Fruhwirth Clemens wrote:

> Hm, alright. So I'm going take the internal of kmap_atomic into
> scatterwalk.c. to test if the page is in highmem, with PageHighMem. If
> it is, I'm going to kmap_atomic and mark the fixmap as used. If it's
> not, I do the "mapping" on my own with page_address.

No, you do not need to do any of this.

Per previous email, all you need is the existing two kmaps, pass the tweak 
in as a linear buffer.

> Btw folks: why are there UpperCamelCase functions in linux/page-flags.h
> and you're whining about my camelcase style in gfmulseq.c? My file isn't
> even intended to be included by other files, unlike this include file.

I don't know why the code is like that, but it is not an excuse to put 
more like it into the kernel.


- James
-- 
James Morris
<jmorris@xxxxxxxxxx>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/