Re: [rfc][patch] ide: fix unneeded LBA48 taskfile registers access

[Jeff Garzik]

Bartlomiej Zolnierkiewicz wrote:
> On Thu, 10 Feb 2005 09:52:25 +0900, Tejun Heo <htejun@xxxxxxxxx> wrote:
>
> >  Okay, another quick question.
> >
> >  To fix the io_32bit race problem in ide_taskfile_ioctl() (and later
> > ide_cmd_ioctl() too), it seems simplest to mark the taskfile with
> > something like ATA_TFLAG_IO_16BIT flag and use the flag in task_in_intr().
> >
> >  However, ATA_TFLAG_* are used by libata, and I think that, although
> > sharing hardware constants is good if the hardware is similar, sharing
> > driver-specific flags isn't such a good idea.  So, what do you think?
> >
> >  1. Add ATA_TFLAG_IO_16BIT to ata.h
> >  2. Make ide's own set of task flags, maybe IDE_TFLAG_* (including
> >     IDE_TFLAG_LBA48)
>
>
> Please add it to <ata.h> (unless Jeff complains loudly),
> I have a patch converting ide_task_t to use struct ata_taskfile
> (except ->protocol for now).

ACK


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/