[2.6 patch] drivers/isdn/tpam/: possible cleanups

[Adrian Bunk]

This patch makes the following possible cleanups:
- tpam_hdlc.c: make the needlessly global variable stuffs static
- tpam_nco.c: remove the unused global function build_ADestroyNCOReq

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

---

 drivers/isdn/tpam/tpam.h      |    1 -
 drivers/isdn/tpam/tpam_hdlc.c |    2 +-
 drivers/isdn/tpam/tpam_nco.c  |   27 ---------------------------
 3 files changed, 1 insertion(+), 29 deletions(-)

--- linux-2.6.11-rc3-mm1-full/drivers/isdn/tpam/tpam_hdlc.c.old	2005-02-09 03:39:54.000000000 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/isdn/tpam/tpam_hdlc.c	2005-02-09 03:40:02.000000000 +0100
@@ -548,7 +548,7 @@
 
 
 static WORD * stuffs[] = { stuff0, stuff1, stuff2, stuff3, stuff4, stuff5 };
-WORD * destuffs[] = { destuff0, destuff1, destuff2, destuff3, destuff4, destuff5 };
+static WORD * destuffs[] = { destuff0, destuff1, destuff2, destuff3, destuff4, destuff5 };
 
 
 /*- AuverTech Telecom -------------------------------------------------------+
--- linux-2.6.11-rc3-mm1-full/drivers/isdn/tpam/tpam.h.old	2005-02-09 03:40:16.000000000 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/isdn/tpam/tpam.h	2005-02-09 03:40:21.000000000 +0100
@@ -181,7 +181,6 @@
 
 /* Function prototypes from tpam_nco.c */
 extern struct sk_buff *build_ACreateNCOReq(const u8 *);
-extern struct sk_buff *build_ADestroyNCOReq(u32);
 extern struct sk_buff *build_CConnectReq(u32, const u8 *, u8);
 extern struct sk_buff *build_CConnectRsp(u32);
 extern struct sk_buff *build_CDisconnectReq(u32);
--- linux-2.6.11-rc3-mm1-full/drivers/isdn/tpam/tpam_nco.c.old	2005-02-09 03:40:29.000000000 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/isdn/tpam/tpam_nco.c	2005-02-09 03:42:52.000000000 +0100
@@ -131,33 +131,6 @@
 }
 
 /*
- * Build a ADestroyNCOReq message.
- *
- * 	ncoid: the NCO id.
- *
- * Return: the sk_buff filled with the NCO packet, or NULL if error.
- */
-struct sk_buff *build_ADestroyNCOReq(u32 ncoid) {
-	struct sk_buff *skb;
-	u8 *tlv;
-
-	pr_debug("TurboPAM(build_ADestroyNCOReq): ncoid=%lu\n",
-		(unsigned long)ncoid);
-
-	/* build the NCO packet */
-	if (!(skb = build_NCOpacket(ID_ADestroyNCOReq, 6, 0, 0, 0)))
-		return NULL;
-	
-	/* add the parameters */
-	tlv = (u8 *)skb_put(skb, 6);
-	*tlv = PAR_NCOID;
-	*(tlv+1) = 4;
-	*((u32 *)(tlv+2)) = ncoid;
-
-	return skb;
-}
-
-/*
  * Build a CConnectReq message.
  *
  * 	ncoid: the NCO id.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/