Re: [PATCH] Altix : ioc4 serial driver support

[Patrick Gefre]

Christoph Hellwig wrote:
> On Mon, Jan 31, 2005 at 04:45:05PM -0600, Pat Gefre wrote:
>
> Please kill ioc4_ide_init as it's completely unused and make ioc4_serial_init
> a normal module_init() handler in ioc4_serial, there's no need to call
> them from the generic driver.

I want ioc4_serial_init called before pci_register_driver() if I make it a
module_init() call I have no control over order ??

> Do you need to use ide_pci_register_driver?  IOC4 doesn't have the legacy
> IDE problems, and it's never used together with such devices in a system,
> so a plain pci_register_driver should do it.

So ide_pci_register_driver is only for legacy devices with certain IDE
problems - I think that is what you are saying (just trying to make sure
I have it right) ??


Thanks for the review,
-- Pat
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/