Re: 2.6.11-rc2-mm2

[Adrian Bunk]

On Mon, Jan 31, 2005 at 12:36:02AM +0100, Roman Zippel wrote:
> Hi,
> 
> On Mon, 31 Jan 2005, Adrian Bunk wrote:
> 
> > WANT_EXPORTFS gets selected by NFSD.
> > 
> > EXPORTFS is usually WANT_EXPORTFS, but if WANT_EXPORTFS=m and 
> > XFS_WANT_EXPORT=y, then EXPORTFS=y.
> > 
> > Since XFS_WANT_EXPORT itself depends on WANT_EXPORTFS this was my 
> > workaround to avoid a circular dependency.
> 
> Why not just let XFS_FS select EXPORTFS directly:
> 
> config XFS_FS
> 	select EXPORTFS if NFSD

This has the wrong semantics:
With NFSD=m and XFS_FS=y it only sets EXPORTFS=m.

> bye, Roman

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/