Re: [PATCH] Resume from initramfs

[Hannes Reinecke]

Matthew Garrett wrote:
> On Mon, 2005-01-31 at 15:09 +0100, Hannes Reinecke wrote:
>
>
> > swsusp_check is used by both entry points, and is itself not a init 
> > function.
> > I simply found it bad style to reference a __init function from there.
> > And name_to_dev_t is evil in itself. I'd gladly be rid of it if possible.
>
>
> name_to_dev_t won't work once userspace has started - you need to
> set_fs(KERNEL_DS) at least one of the calls in it, IIRC.
I'm not advocating to use it.
But referencing a non-existing function is just plain evil.
We should better seperate both entry points to do the necessary device 
resolution themselves before calling generic functions.

Cheers,

Hannes

--
Dr. Hannes Reinecke			hare@xxxxxxx
SuSE Linux AG				S390 & zSeries
MaxfeldstraÃe 5				+49 911 74053 688
90409 NÃrnberg				http://www.suse.de
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/