Re: [PATCH] micro optimization in kernel/params.c; don't callto_module_kobject before we really have to.

[Rusty Russell]

On Sun, 2005-01-30 at 13:43 +0100, Jesper Juhl wrote:
> True, the compiler is free to be clever, but I still think it's best to 
> write the code in the most optimal way as seen from a C perspective. 
> I just took a look at the compiled object files with and without the 
> patch, and it makes no difference what-so-ever - gcc generates the exact 
> same code. So you are right, gcc is clever about it. 

If the code were not already in the kernel, I'd probably apply this.
However, cleanups this trivial are not worthwhile IMHO.

Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/