Re: inter-module-* removal.. small next step

From: Arjan van de Ven
Date: Sun Jan 30 2005 - 15:30:30 EST


On Sun, 2005-01-30 at 11:58 -0800, Andrew Morton wrote:
> Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:
> >
> > On Sun, 2005-01-30 at 19:10 +0100, Adrian Bunk wrote:
> > > On Sun, Jan 30, 2005 at 06:00:17PM +0000, Arjan van de Ven wrote:
> > >
> > > > Hi,
> > > >
> > > > intermodule is deprecated for quite some time now, and MTD is the sole last
> > > > user in the tree. To shrink the kernel for the people who don't use MTD, and
> > > > to prevent accidental return of more users of this, make the compiling of
> > > > this function conditional on MTD.
> > > >...
> > >
> > > agpgart-allow-multiple-backends-to-be-initialized.patch in -mm adds a
> > > call to inter_module_unregister to drivers/char/agp/backend.c ...
> >
> > that is a bug in -mm; inter-module* got removed from agp entirely some
> > time ago
>
> Michael's patches put it back in. What's the fix?

they only put it half in. just drop the one line; it tries to unregister
something that never got registered...
the old cleanup code had to do that, but that got removed. The patch
basically replaces the cleanup code, and thus puts it back in. One line
deleted and it's fine.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/