Re: [2.6 patch] drivers/cdrom/isp16.c: small cleanups

[Adrian Bunk]

On Sat, Jan 29, 2005 at 06:51:25PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Hi,
> 
> On Sat, 29 Jan 2005 18:11:08 +0100, Adrian Bunk <bunk@xxxxxxxxx> wrote:
> > This patch makes the needlessly global function isp16_init static.
> > 
> > As a result, it turned out that both this function and some other code
> > are only required #ifdef MODULE.
> 
> Your patch is correct but it is wrong. ;)
> 
> #ifdefs around isp16_init() need to be removed as
> otherwise this driver is not initialized in built-in case.

It's somehow initialized via isp16_setup.

> Bartlomiej

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/