[PATCH 2.4] I2C updates for 2.4.29 (3/3)

From: Jean Delvare
Date: Sat Jan 29 2005 - 06:39:33 EST


Original discussion:
http://archives.andrew.net.au/lm-sensors/msg29038.html
http://archives.andrew.net.au/lm-sensors/msg29041.html

Bottom line:
The "id" member of the i2c_client structure was discarded in Linux 2.6
due to a lack of consistent use and overall need. While we of course
won't backport this to Linux 2.4 so as to not break compatibility with
existing 2.4 drivers, it still seems wise to update the documentation so
that new drivers written for Linux 2.4 today (*sigh*) do not rely on it.

--- linux-2.4.29/Documentation/i2c/writing-clients.orig 2005-01-21 21:51:06.000000000 +0100
+++ linux-2.4.29/Documentation/i2c/writing-clients 2005-01-23 18:21:47.000000000 +0100
@@ -380,9 +380,6 @@

For now, you can ignore the `flags' parameter. It is there for future use.

- /* Unique ID allocation */
- static int foo_id = 0;
-
int foo_detect_client(struct i2c_adapter *adapter, int address,
unsigned short flags, int kind)
{
@@ -518,7 +515,6 @@
data->type = kind;
/* SENSORS ONLY END */

- new_client->id = foo_id++; /* Automatically unique */
data->valid = 0; /* Only if you use this field */
init_MUTEX(&data->update_lock); /* Only if you use this field */



--
Jean Delvare
http://khali.linux-fr.org/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/