Re: Patch 4/6 randomize the stack pointer

[Julien TINNES]

Not very important but ((get_random_int() % 4096) << 4) could be 
optimized into get_random_int() & 0xFFF0. Because 4096 is a power of 2 
you won't loose any entropy by doing  & 0xFFF instead of %4096

Regards,

--
Julien TINNES - & france telecom - R&D Division/MAPS/NSS
Research Engineer - Internet/Intranet Security
GPG: C050 EF1A 2919 FD87 57C4 DEDD E778 A9F0 14B9 C7D6

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/