Re: [PATCH 2.6.11-rc2] I2C: lm80 driver improvement (From Aurelien)

From: Sytse Wielinga
Date: Wed Jan 26 2005 - 09:10:18 EST


On Wed, Jan 26, 2005 at 02:49:23AM -0500, Shawn Starr wrote:
> static inline unsigned char FAN_TO_REG(unsigned rpm, unsigned div)
> {
> - if (rpm == 0)
> + if (rpm <= 0)
The rpm parameter is unsigned so this change is useless. The rest makes sense
to me.

BTW, can anyone tell me why the uints in this parameter list are declared as
'unsigned' and not as 'unsigned int'?

Sytse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/