Re: make flock_lock_file_wait static

[Arjan van de Ven]

On Tue, 2005-01-25 at 10:58 -0800, Paul E. McKenney wrote:
> On Tue, Jan 11, 2005 at 08:36:22PM +0100, Arjan van de Ven wrote:
> > On Tue, 2005-01-11 at 14:16 -0500, Trond Myklebust wrote:
> > > > (you may think "it's only 100 bytes", well, there are 700+ other such
> > > > functions, total that makes over at least 70Kb of unswappable, wasted
> > > > memory if not more.)
> > > 
> > > A list of these 700+ unused exported APIs would be very useful so that
> > > we can deprecate and/or get rid of them.
> > 
> > http://people.redhat.com/arjanv/unused
> >
> > has the list of symbols that are unused on an i386 allmodconfig based on
> > the -bk tree 2 days ago.
> 
> <donning asbestos suit with the tungsten pinstripes...>
> 
> SAN Filesystem is an out-of-tree GPL module that uses the following:

any plans to submit this for inclusion?

> 
> o	blk_get_queue(): used to submit I/O requests using the
> 	make_request_fn().

sounds really like the wrong level, any reason to not use submit_bio /
submit_bh instead? Every piece of code outside the core block layer that
I've seen that tries to do this has been wrong/broken to date.

> 
> o	sock_setsockopt(): used to control communication with other
> 	nodes in the SAN Filesystem.
> 

again this very much looks like a misuse; sock_setsocketopt() gets a
*userspace* pointer as argument. Bad API to use (and if you look at
CIFS, they would also like a real nice internal api instead, but don't
use sock_setsockopt() since it's the wrong api)


> SDD is a binary module that has committed to get itself to GPL on its
> first release after December 31, 2005.  It uses:
> 
> o	__read_lock_failed() and __write_lock_failed(): due to SDD's use
> 	of read_lock() and write_lock().  So, if the plan is to change
> 	read_lock() and write_lock() to do something different, never mind!

those two exports are "internal" following from copying the
implementation of read_lock() into the code before compiling it (by the
preprocessor) and currently of course won't go away unless readlocks
change/go away.

Another question: is the SDD module even available for mainline kernels,
or is it only available for distribution kernels ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/