Re: Memory leak in 2.6.11-rc1?

[Jens Axboe]

On Mon, Jan 24 2005, Linus Torvalds wrote:
> 
> 
> On Mon, 24 Jan 2005, Andrew Morton wrote:
> > 
> > Would indicate that the new pipe code is leaking.
> 
> Duh. It's the pipe merging.
> 
> 		Linus
> 
> ----
> --- 1.40/fs/pipe.c	2005-01-15 12:01:16 -08:00
> +++ edited/fs/pipe.c	2005-01-24 14:35:09 -08:00
> @@ -630,13 +630,13 @@
>  	struct pipe_inode_info *info = inode->i_pipe;
>  
>  	inode->i_pipe = NULL;
> -	if (info->tmp_page)
> -		__free_page(info->tmp_page);
>  	for (i = 0; i < PIPE_BUFFERS; i++) {
>  		struct pipe_buffer *buf = info->bufs + i;
>  		if (buf->ops)
>  			buf->ops->release(info, buf);
>  	}
> +	if (info->tmp_page)
> +		__free_page(info->tmp_page);
>  	kfree(info);
>  }

It's better now, no leak anymore. But the 2.6.11-rcX vm is still very
screwy, to get something close to nice and smooth behaviour I have to
run a fillmem every now and then to reclaim used memory.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/