Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm

[James Morris]

On Mon, 24 Jan 2005, Andrew Morton wrote:

> These patches clash badly with Michael Ludvig's work:
> 
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc2/2.6.11-rc2-mm1/broken-out/cryptoapi-prepare-for-processing-multiple-buffers-at.patch
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc2/2.6.11-rc2-mm1/broken-out/cryptoapi-update-padlock-to-process-multiple-blocks-at.patch
> 
> so someone's going to have to rework things.  Ordinarily Michael would go
> first due to test coverage.
> 
> James, your call please.  Also, please advise on the suitability of
> Michael's patches for a 2.6.11 merge.

I think the generic scatterwalk changes are more important and 
fundamental (still to be fully reviewed).

I agree with Fruhwirth that the cipher code is starting to become
ungainly.  I'm not sure these patches are heading in the right direction 
from a design point of view, although we do need the functionality.  

Perhaps temporarily drop the multible block changes above until we get the
generic scatterwalk code in and a cleaned up design to handle cipher mode
offload.

Fruhwirth, do you have any cycles to work on implementing your ideas for 
more cleanly reworking Michal's multiblock code?

Also, I would think this is more 2.6.12 material, at this stage.


- James
-- 
James Morris
<jmorris@xxxxxxxxxx>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/