Re: [PATCH 4/29] x86-i8259-shutdown

[Eric W. Biederman]

Dave Jones <davej@xxxxxxxxxx> writes:

> On Mon, Jan 24, 2005 at 10:32:50PM -0500, Len Brown wrote:
>  > On Wed, 2005-01-19 at 02:31, Eric W. Biederman wrote:
>  > > From: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
>  > > 
>  > > This patch disables interrupt generation from the legacy pic on
>  > > reboot.  Now that there is a sys_device class it should not be called
>  > > while drivers are still using interrupts.
>  > > 
>  > > There is a report about this breaking ACPI power off on some systems.
>  > > http://bugme.osdl.org/show_bug.cgi?id=4041
>  > > However the final comment seems to exhonorate this code.  So until
>  > > I get more information I believe that was a false positive.
>  > 
>  > No, the last comment in the bug report
>  > (davej says that there were poweroff problems in FC)
>  > does not exhonerate this patch.
>  > All it says is that there are additional poweroff bugs out there.

So I will ask again, as I did when Andrew first pointed this in my
direction.  What code path in the kernel could possibly care if we
disable the i8259 after we have disabled all of the other hardware in
the system.

The i8259 is a system device so everything else is shutoff first
(by design).  I have one vague reference that this is a/the
problem but I don't have anything to go on with respect to fixing it.

I don't have a system that reproduces this.

Eric

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/