[PATCH] Prevent NMI oopser

From: Vasily Averin
Date: Tue Jan 25 2005 - 02:50:58 EST


Marcello, Andrey

I believe this patch is wrong.
First, it prevent nothing: NMI watchdog is a signal that you wait too long with disabled interrupts. Your controller was not answered too long, obviously it is a hardware issue.
Second, you could not call schedule() with io_request_lock spinlock taken.

You should unlock io_request_lock before msleep, like in latest versions of megaraid2 drivers.

Please fix it.

Thank you,
Vasily Averin, SWSoft Linux Kernel Team

# ChangeSet
# 2005/01/19 14:16:32-02:00 temnota@xxxxxx
# [PATCH] Prevent NMI oopser from triggering when megaraid2 waits
# for abort/reset cmd completion
#
# > We should backport msleep() in 2.4.29-pre1.
#
# Ok, msleep() backported, but driver isn't fixed. This patch
# acceptable?
#
# Prevent NMI oopser kill kernel thread when megaraid2 driver waiting
# abort or reset command completion.
#
# Signed-off-by: Andrey Melnikov <temnota+kernel@xxxxxx>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/