Re: [PATCH] fix bad locking in drivers/base/driver.c

From: Greg KH
Date: Tue Jan 25 2005 - 00:58:20 EST


On Mon, Jan 24, 2005 at 07:25:19PM +0100, Jirka Kosina wrote:
> Hi,
>
> there has been (for quite some time) a bug in function driver_unregister()
> - the lock/unlock sequence is protecting nothing and the actual
> bus_remove_driver() is called outside critical section.
>
> Please apply.

No, please read the comment in the code about why this is the way it is.
The code is correct as is.

Also, please CC the driver core maintainer next time for patches like
this so I don't miss them when they go by.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/