Re: [torvalds@osdl.org: Re: Memory leak in 2.6.11-rc1?]

[Bryce Harrington]

Hi Chris,

I applied the patch and reran the test on a RH 9.0 system.  LTP is
continuing past where it failed before, and processes are not getting
killed, so I assume the OOM killer is no longer getting activated.

There is a new behavior, though.  Now the test is hanging indefinitely
on the nptl01 test.  I am assuming that since it passed the spot that it
had failed before, that this is an unrelated issue.

Bryce


On Mon, 24 Jan 2005, Chris Wright wrote:
> Any chance you could re-try with this patch applied?
>
> ----- Forwarded message from Linus Torvalds <torvalds@xxxxxxxx> -----
>
> Date: 	Mon, 24 Jan 2005 14:35:47 -0800 (PST)
> From: Linus Torvalds <torvalds@xxxxxxxx>
> To: Andrew Morton <akpm@xxxxxxxx>
> cc: Jens Axboe <axboe@xxxxxxx>, alexn@xxxxxxxxx, kas@xxxxxxxxxx,
>    linux-kernel@xxxxxxxxxxxxxxx, lennert.vanalboom@xxxxxxxx
> Subject: Re: Memory leak in 2.6.11-rc1?
>
>
>
> On Mon, 24 Jan 2005, Andrew Morton wrote:
> >
> > Would indicate that the new pipe code is leaking.
>
> Duh. It's the pipe merging.
>
> 		Linus
>
> ----
> --- 1.40/fs/pipe.c	2005-01-15 12:01:16 -08:00
> +++ edited/fs/pipe.c	2005-01-24 14:35:09 -08:00
> @@ -630,13 +630,13 @@
>  	struct pipe_inode_info *info = inode->i_pipe;
>
>  	inode->i_pipe = NULL;
> -	if (info->tmp_page)
> -		__free_page(info->tmp_page);
>  	for (i = 0; i < PIPE_BUFFERS; i++) {
>  		struct pipe_buffer *buf = info->bufs + i;
>  		if (buf->ops)
>  			buf->ops->release(info, buf);
>  	}
> +	if (info->tmp_page)
> +		__free_page(info->tmp_page);
>  	kfree(info);
>  }
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
> ----- End forwarded message -----
>
>



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/