Re: [PATCH] lib/qsort

[Matt Mackall]

On Mon, Jan 24, 2005 at 03:09:40PM -0800, Andrew Morton wrote:
> Matt Mackall <mpm@xxxxxxxxxxx> wrote:
> >
> > This patch introduces an implementation of qsort to lib/.
> 
> It screws me over right proper.  Can we stick with Andreas's known-working
> patch for now, and do the sorting stuff as a separate, later activity?
> 
> It would involve:
> 
> - Removal of the old sort code
> 
> - Introduction of the new sort code
> 
> - Migration of the NFS ACL code, XFS and group code over to the new
>   implementation.

Ok, will do after mm++.

FYI, I'm going to submit a heapsort variant instead with similar
performance. It gets rid of the potentially exploitable worst-case
behavior of qsort as well as the extra stack space (and the resultant
need for error handling).

Apparently the glibc folks wanted this to be EXPORT_SYMBOL_GPL the
last time around, btw.

-- 
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/