Re: [PATCH] Problems disabling SYSCTL

From: Andi Kleen
Date: Mon Jan 24 2005 - 11:02:30 EST


On Tue, Jan 25, 2005 at 12:50:01AM +1100, Anton Blanchard wrote:
>
> > > Is there any reason to not move the sys32_sysctl code to kernel/sysctl.c?
> >
> > iirc it relies on a unified address space (= user pointers still
> > work in KERNEL_DS)
>
> Yeah the sys32_sysctl code is pretty awful, perhaps we could do a better
> job now we have compat_alloc_userspace.

It also mishandles array of longs.

But seriously I wouldn't bother - the syscall interface is deprecated anyways
and has been for a long time. The only sysctl that needs to be handled
is (CTL_KERN,KERN_VERSION) [used by glibc], the others are not needed
and I hoep to eventually remove them even natively.

-Andi

P.S.: Andrew I just discovered you removed the printk code for this.
That's not good, how are users supposed to know it's deprecated?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/