Re: RFC: [2.6 patch] let BLK_DEV_UB depend on USB_STORAGE=n

[David Woodhouse]

On Wed, 2005-01-19 at 14:07 -0800, Greg KH wrote:
> I have been running with just the code portion of this patch for a while
> now, with good results (no Kconfig changes.)
> 
> Pete and Matt, do you mind me applying the following portion of the
> patch to the kernel tree?
> 
> > -#if !defined(CONFIG_BLK_DEV_UB) && !defined(CONFIG_BLK_DEV_UB_MODULE)
> >  UNUSUAL_DEV(  0x0781, 0x0002, 0x0009, 0x0009, 
> >  		"Sandisk",
> >  		"ImageMate SDDR-31",
> >  		US_SC_DEVICE, US_PR_DEVICE, NULL,
> >  		US_FL_IGNORE_SER ),
> > -#endif

Urgh. Please do. Code which may compile differently in the kernel image
according to which _modules_ are configured at the time is horrid, and
should be avoided.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/