Re: [PATCH 1/5] compat_ioctl call seems to miss a security hook

From: Michael S. Tsirkin
Date: Wed Jan 19 2005 - 20:11:36 EST


Quoting r. Chris Wright (chrisw@xxxxxxxx) "Re: [PATCH 1/5] compat_ioctl call seems to miss a security hook":
> * Michael S. Tsirkin (mst@xxxxxxxxxxxxxx) wrote:
> > I'm all for it, but the way the patch below works, we could end up
> > calling ->ioctl or ->unlocked_ioctl from the compat
> > syscall, and we dont want that.
>
> Hmm, I didn't actually change how those are called. So if it's an issue,
> then I don't think this patch introduces it.
>
> thanks,
> -chris

Sorry, you are right, we go to do_ioctl only if there are no
callbacks.
Patch looks good to go to me.
mst
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/