Re: [PATCH] Can't unmount bad inode

From: Miklos Szeredi
Date: Wed Jan 19 2005 - 17:10:25 EST


> > This patch fixes a problem when a inode which is the root of a mount
> > becomes bad (make_bad_inode()). In this case follow_link will return
> > -EIO, so the name resolution fails, and umount won't work. The
> > solution is just to remove the follow_link method from bad_inode_ops.
> > Any filesystem operation (other than unmount) will still fail, since
> > every other method returns -EIO.
>
> I'm not all that sure that we want to follow symlinks in the last
> pathname component upon umount, actually...

That could break existing usage, couldn't it? The damage wouldn't be
too bad I guess, but still it would be a bigger change, than fixing
bad_inode.

Miklos

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/