Re: [PATCH 19/29] x86_64-kexec

[Andi Kleen]

"Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> writes:

[note an extensive review of all this code, but from a quick read...]

> +
> +static void load_segments(void)
> +{
> +	__asm__ __volatile__ (
> +		"\tmovl $"STR(__KERNEL_DS)",%eax\n"
> +		"\tmovl %eax,%ds\n"
> +		"\tmovl %eax,%es\n"
> +		"\tmovl %eax,%ss\n"
> +		"\tmovl %eax,%fs\n"
> +		"\tmovl %eax,%gs\n"
> +		);

This misses an clobber for "eax" 


-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/