Re: PCI patches not being reviewed

From: Greg KH
Date: Tue Jan 18 2005 - 11:30:22 EST


On Tue, Jan 18, 2005 at 12:21:26PM +0000, Matthew Wilcox wrote:
> On Mon, Jan 17, 2005 at 10:27:22PM -0800, Greg KH wrote:
> > On Tue, Jan 18, 2005 at 02:20:31AM +0000, Matthew Wilcox wrote:
> > >
> > > Greg, you're merging a lot of patches that aren't going through
> > > the linux-pci mailing list for review. Please redirect patches that
> > > are sent to you directly so others can also review them.
> >
> > I'm sorry, were there any that were recently applied that you feel
> > needed more review?
>
> Yes, the PCI Express bridge driver is quite buggy.

It was posted a number of times to lkml in December, and it was
commented on by a few different people, and the patch went through a few
different revisions. It also was in the -mm tree for awhile.

> I also think it's the wrong approach to take -- weren't you working on
> a generic way to have multiple drivers attach to the same device?

That's what the patch allows to happen. I think it's the right
approach, what do you think it should do?

> > All major ones have been posted to linux-kernel
> > first, which, according to the MAINTAINERS file, is the list for pci
> > issues to be disccused on. I'd be glad to change that entry, if you
> > think it would help out any.
>
> That would certainly help; I'm not sure how anyone has time to read
> linux-kernel. Here's a patch:

Hm, in sleeping on it, I think I'll leave it, as it's worked out just
fine for me for the past 2+ years I've been the PCI maintainer, this has
been the first it has come up. But if it really annoys you, how about
just adding another L: entry for it, so people can choose where they
want to go?

Oh, and you forgot the Signed-off-by: line :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/