Re: [PATCH] SCSI NCR53C9x.c: some cleanups

From: Geert Uytterhoeven
Date: Mon Jan 17 2005 - 07:51:01 EST


On Tue, 21 Dec 2004, Linux Kernel Mailing List wrote:
> ChangeSet 1.2034.61.36, 2004/12/21 09:41:18-06:00, bunk@xxxxxxxxx
>
> [PATCH] SCSI NCR53C9x.c: some cleanups
>
> Make two functions static

> --- a/drivers/scsi/NCR53C9x.c 2004-12-28 23:32:55 -08:00
> +++ b/drivers/scsi/NCR53C9x.c 2004-12-28 23:32:55 -08:00
> @@ -505,7 +505,7 @@
> }
>
> /* This places the ESP into a known state at boot time. */
> -void esp_bootup_reset(struct NCR_ESP *esp, struct ESP_regs *eregs)
> +static void esp_bootup_reset(struct NCR_ESP *esp, struct ESP_regs *eregs)
> {
> volatile unchar trash;
>

This change breaks the Amiga Oktagon SCSI driver (drivers/scsi/oktagon_esp.c),
which calls esp_bootup_reset().

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/