Re: [PATCH 2/8 ] ltt for 2.6.10 : core headers

[Sam Ravnborg]

Hi Karim.

> +++ linux-2.6.10-relayfs-ltt/include/linux/ltt-core.h	2005-01-13 22:21:56.000000000 -0500
> @@ -0,0 +1,430 @@
> +/*
> + * linux/include/linux/ltt-core.h
> + *
> + * Copyright (C) 1999-2004 Karim Yaghmour (karim@xxxxxxxxxxx)
> + *
> + * This contains the core definitions for the Linux Trace Toolkit.
> + */
include/linux/*.h is supposed to include only definitions used by other
parts of the kernel.
Definitions used only internally by ltt shall stay in kernel/

This is generally agreed upon, but not yet common practice.

Btw. did you run it through sparse?
Not that I found something, but did not see sparse annotation at first
sight.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/