Re: swsusp: more small fixes

[Pavel Machek]

Hi!

> > -struct highmem_page *highmem_copy = NULL;
> > +static struct highmem_page *highmem_copy = NULL;
> 
> You could remove explicit initialization (so pointer would go into bss
> instead of data, IIRC).
> 
> > -		pr_debug("suspend: Allocating pagedir failed.\n");
> > +		printk("suspend: Allocating pagedir failed.\n");
> 
> Missing KERN_ constant.

> > -		pr_debug("suspend: Allocating image pages failed.\n");
> > +		printk("suspend: Allocating image pages failed.\n");
> 
> Same here.

Fixed, but I'd prefer to have this applied and fix it with followup
patch.
								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/