Re: Kernel conector. Reincarnation #1.

From: Evgeniy Polyakov
Date: Wed Jan 12 2005 - 15:25:20 EST


On Wed, 12 Jan 2005 11:03:19 -0800
Greg KH <greg@xxxxxxxxx> wrote:

> On Wed, Dec 22, 2004 at 12:21:12PM +0300, Evgeniy Polyakov wrote:
> > Hello, Greg, developers.
> >
> > This is first public resending of connector patch after several private
> > discussions.
> > Noone objected before, so if there are no complaints, Greg, please
> > apply.
>
> one minor issue:
>
> > +#include "../connector/connector.h"
>
> Shouldn't connector.h go into include/linux so that everyone can use it
> within the kernel? If so, then it's dependancy on cn_queue.h needs to
> be fixed up too (why not just merge them both together)?
>
> > +#include "../connector/cn_queue.h"
>
> This can just be:
> #include "cn_queue.h"
> if you end up still needing it.

Yep, I've fixed that.
Now it has only one header connector.h in linux/ include directory.

>
> Sorry for taking so long to get back to this, was on vacation.

Do not mention, hope they were cool.

> thanks,
>
> greg k-h


Evgeniy Polyakov

Only failure makes us experts. -- Theo de Raadt

Attachment: connector.patch
Description: Binary data

Attachment: connector.patch.drivers_Kconfig
Description: Binary data

Attachment: connector.patch.drivers_Makefile
Description: Binary data