Re: [PATCH 3/11] FUSE - device functions

From: Mike Waychison
Date: Tue Jan 11 2005 - 13:23:31 EST


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Miklos Szeredi wrote:
> This adds the FUSE device handling functions.
>
> This contains the following files:
>
> o dev.c
> - fuse device operations (read, write, release, poll)
> - registers misc device
> - support for sending requests to userspace
>
> Signed-off-by: Miklos Szeredi <miklos@xxxxxxxxxx>
> diff -Nurp a/fs/fuse/Makefile b/fs/fuse/Makefile
> --- a/fs/fuse/Makefile 2005-01-10 19:28:38.000000000 +0100
> +++ b/fs/fuse/Makefile 2005-01-10 19:28:38.000000000 +0100
> @@ -4,4 +4,4 @@
>
> obj-$(CONFIG_FUSE) += fuse.o
>
> -fuse-objs := inode.o
> +fuse-objs := dev.o inode.o
> diff -Nurp a/fs/fuse/dev.c b/fs/fuse/dev.c
> --- a/fs/fuse/dev.c 1970-01-01 01:00:00.000000000 +0100
> +++ b/fs/fuse/dev.c 2005-01-10 19:28:38.000000000 +0100

[...]

> +static inline void block_sigs(sigset_t *oldset)
> +{
> + sigset_t sigmask;
> +
> + siginitsetinv(&sigmask, sigmask(SIGKILL));
> + sigprocmask(SIG_BLOCK, &sigmask, oldset);

sigmask shadows sigmask. I'm surprised this works actually. (I see that
sigmask() is a macro..)


- --
Mike Waychison
Sun Microsystems, Inc.
1 (650) 352-5299 voice
1 (416) 202-8336 voice

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
NOTICE: The opinions expressed in this email are held by me,
and may not represent the views of Sun Microsystems, Inc.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFB5A0ZdQs4kOxk3/MRAvJfAJ9AqZqRWRKpRww2zJVaM4gsDq00lQCgjp4Q
Bh+GXSiI/mAx3rghwFvT9UA=
=U2iZ
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/