Re: [PATCH 2/6] 2.4.19-rc1 number() stack reduction

[Badari Pulavarty]

Greg-KH told me that, this patch is useless.  He told me that,
this won't save any stack since  "static constants" won't be
on the stack. I will take his word for it :)

Please ignore this patch.

Thanks,
Badari

Badari Pulavarty wrote:

> ------------------------------------------------------------------------
>
> Signed-off-by: Badari Pulavarty <pbadari@xxxxxxxxxx>
> --- linux-2.4.29-rc1.org/lib/vsprintf.c	2004-02-18 05:36:32.000000000 -0800
> +++ linux-2.4.29-rc1/lib/vsprintf.c	2005-01-07 07:56:00.000000000 -0800
> @@ -128,12 +128,16 @@ static int skip_atoi(const char **s)
>  #define SPECIAL	32		/* 0x */
>  #define LARGE	64		/* use 'ABCDEF' instead of 'abcdef' */
>  
> + /* Move these off of the stack for number().  This way we reduce the
> +  * size of the stack and don't have to copy them every time we are called.
> +  */
> +const char small_digits[] = "0123456789abcdefghijklmnopqrstuvwxyz";
> +const char large_digits[] = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ";
> +
>  static char * number(char * buf, char * end, long long num, int base, int size, int precision, int type)
>  {
>  	char c,sign,tmp[66];
>  	const char *digits;
> -	static const char small_digits[] = "0123456789abcdefghijklmnopqrstuvwxyz";
> -	static const char large_digits[] = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ";
>  	int i;
>  
>  	digits = (type & LARGE) ? large_digits : small_digits;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/