Re: [PATCH] PCI patches for 2.6.10

[Greg KH]

ChangeSet 1.1938.439.47, 2005/01/07 10:33:57-08:00, eike-hotplug@xxxxxxxxx

[PATCH] PCI Hotplug: don't check pointer before kalling kfree in ibmphp_pci.c

Calling kfree() with a NULL pointer is no error so we don't need this check.

Signed-off-by: Rolf Eike Beer <eike-hotplug@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <greg@xxxxxxxxx>


 drivers/pci/hotplug/ibmphp_pci.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)


diff -Nru a/drivers/pci/hotplug/ibmphp_pci.c b/drivers/pci/hotplug/ibmphp_pci.c
--- a/drivers/pci/hotplug/ibmphp_pci.c	2005-01-10 08:58:38 -08:00
+++ b/drivers/pci/hotplug/ibmphp_pci.c	2005-01-10 08:58:38 -08:00
@@ -1062,8 +1062,7 @@
 	}
 
 error:
-	if (amount_needed)
-		kfree (amount_needed);
+	kfree(amount_needed);
 	if (pfmem)
 		ibmphp_remove_resource (pfmem);
 	if (io)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/