Re: [PATCH 2.6.10-mm2] Use the new preemption code [3/3]

[Tom Rini]

On Mon, Jan 10, 2005 at 02:00:04AM +0100, Thomas Gleixner wrote:

> This patch adjusts the PPC entry code to use the fixed up
> preempt_schedule() handling in 2.6.10-mm2
> 
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> 
> ---
>  entry.S |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> ---
> Index: 2.6.10-mm1/arch/ppc/kernel/entry.S
> ===================================================================
> --- 2.6.10-mm1/arch/ppc/kernel/entry.S  (revision 141)
> +++ 2.6.10-mm1/arch/ppc/kernel/entry.S  (working copy)
> @@ -624,12 +624,12 @@
>         beq+    restore
>         andi.   r0,r3,MSR_EE    /* interrupts off? */
>         beq     restore         /* don't schedule if so */
> -1:     lis     r0,PREEMPT_ACTIVE@h
> +1:     li      r0,1

Perhaps I just don't have enough context, but is there good reason to
use a magic constant instead of a define ?

-- 
Tom Rini
http://gate.crashing.org/~trini/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/