Re: [PATCH] x86_64: Notify user of MCE events (updated)

[Zwane Mwaikambo]

On Sun, 9 Jan 2005, Andi Kleen wrote:

> Zwane Mwaikambo <zwane@xxxxxxxxxxxxxxxx> writes:
> > +	 */
> > +	if (notify_user && console_logged) {
> > +		notify_user = 0;
> > +		clear_bit(0, &console_logged);
> > +		printk(KERN_EMERG "Machine check exception logged\n");
> 
> Another suggestion: don't make this KERN_EMERG. Make it KERN_INFO. 
> Logged errors are usually correct, so there is no need for an 
> emergency.
> 
> Also since these are not always exceptions (but can be read from
> the polling timer) I would call them "machine check events" 

Thanks for the comments, i've updated the patch.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/